Add machineset.yaml.template to vsphere example #318
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @k4leung4 /assign @roberthbailey |
|
/hold Until #316 is working |
k8s-ci-robot
added
the
do-not-merge/hold
| apiVersion: "cluster.k8s.io/v1alpha1" | ||
| kind: MachineSet | ||
| metadata: | ||
| name: karangoel-ms-1 |
There was a problem hiding this comment.
remove karangoel from here: something like test-machineset-1 or vsphere-nodes or something would make more sense.
| network: "" | ||
| num_cpus: "2" | ||
| memory: "2048" | ||
| vm_template: "ubuntu-xenial-16.04-cloudimg-20180504" |
There was a problem hiding this comment.
this is blank in https://github.com/kubernetes-sigs/cluster-api/blob/master/clusterctl/examples/vsphere/machines.yaml.template; should it be blank here too?
| memory: "2048" | ||
| vm_template: "ubuntu-xenial-16.04-cloudimg-20180504" | ||
| disk_label: "" | ||
| disk_size: "10" |
There was a problem hiding this comment.
| metadata: | ||
| name: karangoel-ms-1 | ||
| spec: | ||
| replicas: 1 |
There was a problem hiding this comment.
should we default to 2 so that it's clear how this is different than individual machines?
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
* Add machineset.yaml.template to vsphere example * cleanup manifest
What this PR does / why we need it: Add a sample machineset.yaml template